Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Server-side data source with row grouping #13826

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

[DataGridPremium] Server-side data source with row grouping #13826

wants to merge 43 commits into from
+1,547 −113

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Jul 15, 2024 •
edited
Loading

👨‍💻 Ready for Review 👨‍💻

Part of #8179
Resolves #10859

Preview: https://deploy-preview-13826--material-ui-x.netlify.app/x/react-data-grid/server-side-data/row-grouping/

Action items

  • Add support for groupingValueGetter
  • Support row grouping features on useMockServer:
    • Sorting
    • Filtering
    • Pagination
    • Support more datasets
  • Rows with missing groups
  • Fix Argos' regression
  • Add/refine documentation

Follow-ups:

  • Support sort and filter on the Group column(s) for row grouping and tree data
  • Test coverage

@MBilalShafi MBilalShafi added component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request plan: Premium Impact at least one Premium user feature: Row grouping Related to the data grid Row grouping feature feature: Server integration Better integration with backends, e.g. data source labels Jul 15, 2024
@mui-bot
Copy link

mui-bot commented Jul 15, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13826--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 7491df5

@tommy-wl
Copy link

Hi @MBilalShafi, are you able to provide an ETA for this? Thank you!

@MBilalShafi
Copy link
Member Author

Hey @tommy-wl, thank you for reaching out.

The ETA for this feature is around the end of Q3, its currently one of the main focus areas for the team. Feel free to test the under development feature and provide some early feedback if you want.

@MBilalShafi MBilalShafi changed the title [DataGridPremium] Server-side row grouping [DataGridPremium] Server-side data source with row grouping Jul 22, 2024
@MBilalShafi MBilalShafi mentioned this pull request Aug 15, 2024
Closed
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 22, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 4, 2024
@MBilalShafi
Update a line of doc
c60b757 
Signed-off-by: Bilal Shafi <[email protected]>
@MBilalShafi MBilalShafi requested review from a team and arminmeh October 11, 2024 13:10
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 16, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk left review comments

@arminmeh arminmeh arminmeh approved these changes

@joserodolfofreitas joserodolfofreitas Awaiting requested review from joserodolfofreitas

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Row grouping Related to the data grid Row grouping feature feature: Server integration Better integration with backends, e.g. data source new feature New feature or request plan: Premium Impact at least one Premium user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Implement server-side data source in row grouping
7 participants
@MBilalShafi @mui-bot @tommy-wl @forwardslahsdotj @romgrk @arminmeh @oliviertassinari